Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build multiple 3DSX files (one per cargo artifact) #60

Merged
merged 8 commits into from
Jun 16, 2024

Conversation

ian-h-chamberlain
Copy link
Member

@ian-h-chamberlain ian-h-chamberlain commented Jun 14, 2024

Closes #44

Trying again for #58 ! I think this is a bit cleaner / less churn vs what I had there.

Two main components here:

  • Make CTRConfig implement Deserialize, and use that to parse metadata instead of manually walking the Cargo.toml. We already collected the metadata once, so we can just pass it through everywhere.
  • Run build callbacks once per artifact instead of just once. After all build callbacks are done, then try to run any additional callbacks, failing if we were asked to run more than one executable / test.

TODOs:

For each executable artifact generated by the build command, run the
build callback on it. Then, if there is only one artifact, run the
run/test callback on it.
@ian-h-chamberlain ian-h-chamberlain self-assigned this Jun 14, 2024
@ian-h-chamberlain ian-h-chamberlain requested a review from a team as a code owner June 14, 2024 04:50
Copy link
Member

@Meziu Meziu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the target configuration in Cargo.toml! I hope to see the ability to run swarms of examples in the near future 😄.

src/command.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/command.rs Outdated Show resolved Hide resolved
src/command.rs Outdated Show resolved Hide resolved
src/command.rs Outdated Show resolved Hide resolved
@ian-h-chamberlain ian-h-chamberlain merged commit 7fd38e2 into master Jun 16, 2024
3 checks passed
@ian-h-chamberlain ian-h-chamberlain deleted the feature/multiple-outputs-take2 branch June 16, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build 3dsx for *all* executables built by a given command
2 participants